Adds cop to enforce assert_instance_of over assert(object.instance_of?(Class)) #34
+151
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 26, 2019
config/default.yml
Outdated
| @@ -21,6 +21,12 @@ Minitest/AssertIncludes: | |||
| Enabled: true | |||
| VersionAdded: '0.2' | |||
|
|
|||
| Minitest/AssertInstanceOf: | |||
| Description: 'This cop enforces the use of `assert_instance_of(Class, object)` over `assert(object.instance_of?(Class))`' | |||
There was a problem hiding this comment.
Maybe a typo?
-Description: 'This cop enforces the use of `assert_instance_of(Class, object)` over `assert(object.instance_of?(Class))`'
+Description: 'This cop enforces the test to use `assert_instance_of(Class, object)` over `assert(object.instance_of?(Class))`'
koic
reviewed
Oct 26, 2019
| module Cop | ||
| module Minitest | ||
| # This cop enforces the use of `assert_instance_of(Class, object)` | ||
| # over `assert(object.instance_of?(Class))`. |
There was a problem hiding this comment.
abhaynikam
force-pushed
the
adds-cop-for-assert-instance-of
branch
from
689166d
to
ddc7ae4
Compare
abhaynikam
force-pushed
the
adds-cop-for-assert-instance-of
branch
from
ddc7ae4
to
c072f87
Compare
|
@koic : Fixed the comments. Could you please review this PR again? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds cops to enforce the use of assert_instance_of over assert(object.instance_of?(Class))
Ref: https://github.com/rubocop-hq/minitest-style-guide#assert-instance-of